[MOO-1887]: Fix initial slide positioning in IntroScreen widget [MX 11] #282
+1,512
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UrazAkgultan
force-pushed
the
fix/intro-screen-mx11
branch
from
c523430 to
6bd6983
Compare
| @@ -71,16 +71,19 @@ | |||
| "husky": "^8.0.3", | |||
| "identity-obj-proxy": "^3.0.0", | |||
| "image-js": "^0.35.6", | |||
| "jest": "^30.0.4", | |||
There was a problem hiding this comment.
this has to match the version in @mendix/pluggable-widgets-tools
| "lint-staged": "^10.5.4", | ||
| "mendix-client": "^7.15.8", | ||
| "patch-package": "^8.0.0", | ||
| "pixelmatch": "^5.3.0", | ||
| "pngjs": "^6.0.0", | ||
| "prettier": "^2.8.8", | ||
| "pretty-format": "^30.0.2", |
There was a problem hiding this comment.
where is this dependency used?
| ); | ||
|
|
||
| useEffect(() => { | ||
| const slide = refreshActiveSlideAttribute(props.slides, props.activeSlide); | ||
| if (width && props.activeSlide && props.activeSlide.status === ValueStatus.Available && slide !== activeIndex) { |
There was a problem hiding this comment.
You should be able to use "?." here and skip the "&& props.activeSlide" bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
Currently, when activeSlide is set to a non-zero value, the IntroScreen always opens on the first slide. This happens because the effect that calls scrollToOffset runs too late (or not at all) and its dependency array doesn’t include the slide value/status, so the FlatList never scrolls to the desired index on mount.